Merge pull request #1371 from ploxiln/test_go_vet

test: add "go vet"
nsqio · Sep 5, 2021 · d21ec48 · d21ec48
2 parents 45febac + d676737
commit d21ec48
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/nsqadmin/nsqadmin.go b/nsqadmin/nsqadmin.go
@@ -100,7 +100,6 @@ func New(opts *Options) (*NSQAdmin, error) {
 		url, err := url.Parse(opts.GraphiteURL)
 		if err != nil {
 			return nil, fmt.Errorf("failed to parse --graphite-url (%s) - %s", opts.GraphiteURL, err)
-			os.Exit(1)
 		}
 		n.graphiteURL = url
 	}

diff --git a/test.sh b/test.sh
@@ -20,6 +20,9 @@ for dir in apps/*/ bench/*/; do
     fi
 done
 
+# disable "composite literal uses unkeyed fields"
+go vet -composites=false ./...
+
 FMTDIFF="$(find apps internal nsqd nsqlookupd -name '*.go' -exec gofmt -d '{}' ';')"
 if [ -n "$FMTDIFF" ]; then
     printf '%s\n' "$FMTDIFF"