fix(nsqd):concurrency safety

nsqio · Apr 26, 2023 · cfbd287 · cfbd287
1 parent 1362af1
commit cfbd287
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/nsqd/channel.go b/nsqd/channel.go
@@ -436,9 +436,10 @@ func (c *Channel) RemoveClient(clientID int64) {
 
 	c.Lock()
 	delete(c.clients, clientID)
+	numClients := len(c.clients)
 	c.Unlock()
 
-	if len(c.clients) == 0 && c.ephemeral {
+	if numClients == 0 && c.ephemeral {
 		go c.deleter.Do(func() { c.deleteCallback(c) })
 	}
 }