fix imagePullSecrets helper func

[realHarter]

What?

Fix imagePullSecret helper function

Why?

When using imagePullSecrets in the values.yaml like:

imagePullSecrets:
  - name: secret1
  - name: secret2

the nsqd-lookupd and nsqd-admin deployment append it correct using:

{{- with .Values.imagePullSecrets }}
      imagePullSecrets:
        {{- toYaml . | nindent 8 }}
{{- end }}

The nsqd-statefulset however uses the helper function:

{{- include "nsq.imagePullSecrets" . | nindent 6 }}

which results in the deployment to look like:

imagePullSecrets:
  - name: map[name:secret1]
  - name: map[name:secret2]

The pull secrets can't be resolved leading to an img pull error in the deployment.

How?

When building the list in the helper function, use only the name instead if the key,value pair.

[ploxiln]

Maybe the nsqd template should do the same thing for imagePullSecrets as nsqlookupd and nsqadmin do, and the helper should be removed?

[ploxiln]

(also, can you bump chart patch version?)

[realHarter]

As far as I understand it the helper merges the imagePullSecrets for the main nsq image aswell as the metrics image together. Since the nsqd deployment needs them both deleting the helper function would break the deployment there.

But I agree that there is probably a better way to do it, that was just the first fix that came into my mind.

[ploxiln]

ah, ok, thanks