Exec changes for 3.4.0 #2613
Merged
Exec changes for 3.4.0 #2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That are only entry scripts today. See neo-project/neo#2796.
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 84.51% 84.49% -0.02%
==========================================
Files 299 301 +2
Lines 37882 38115 +233
==========================================
+ Hits 32016 32206 +190
- Misses 4458 4503 +45
+ Partials 1408 1406 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
roman-khimov
commented
Jul 28, 2022
roman-khimov
force-pushed
the
exec-changes-3.4.0
branch
from
d8f9564 to
4ea430f
Compare
AnnaShaleva
reviewed
Aug 5, 2022
AnnaShaleva
reviewed
Aug 5, 2022
Local calls reuse them, cross-contract calls create new ones. This allows to avoid some allocations and use a little less memory.
I think it's OK as is. |
roman-khimov
force-pushed
the
exec-changes-3.4.0
branch
from
4ea430f to
257d2e2
Compare
AnnaShaleva
reviewed
Aug 5, 2022
Directly check contexts.
And determine the need for Null dynamically. For some reason the only dynamic context is Contract.Call. CALLT is not dynamic and neither is a call from native contract, go figure...
roman-khimov
force-pushed
the
exec-changes-3.4.0
branch
from
257d2e2 to
e8d2277
Compare
AnnaShaleva
approved these changes
Aug 5, 2022
|
I guess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See neo-project/neo#2796.