-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpc: add NEP11 and NNS interfaces to RPC Client #1857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1857 +/- ##
==========================================
- Coverage 83.31% 83.20% -0.12%
==========================================
Files 283 286 +3
Lines 22467 22581 +114
==========================================
+ Hits 18719 18788 +69
- Misses 2592 2622 +30
- Partials 1156 1171 +15
Continue to review full report at Codecov.
|
roman-khimov
requested changes
Mar 25, 2021
This was referenced Mar 26, 2021
Some of them are shared between multiple RPC client APIs, so let's keep them in a separate place for better maintainability.
We need this to avoid `native` dependency in RPC client.
It is needed for RPC client integration tests.
We don't need magic to create tx anymore, but we need it to sign tx.
roman-khimov
approved these changes
Mar 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1836