Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging on Windows #2269

Closed
AnnaShaleva opened this issue Nov 18, 2021 · 0 comments · Fixed by #2353
Closed

Fix logging on Windows #2269

AnnaShaleva opened this issue Nov 18, 2021 · 0 comments · Fixed by #2353
Labels
windows Windows platform
Milestone

Comments

@AnnaShaleva
Copy link
Member

Problem
Absolute logger paths are not supported by zap logger (uber-go/zap#621, uber-go/zap#624). As example, see the failing test:

2021-11-17T15:46:00.8922873Z === RUN   TestHandleLoggingParams/default
2021-11-17T15:46:00.8923506Z     server_test.go:53: 
2021-11-17T15:46:00.8923992Z         	Error Trace:	server_test.go:53
2021-11-17T15:46:00.8924596Z         	Error:      	Received unexpected error:
2021-11-17T15:46:00.8925814Z         	            	couldn't open sink "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestHandleLoggingParams150626778\\001\\file.log": no sink found for scheme "c"
2021-11-17T15:46:00.8927627Z         	Test:       	TestHandleLoggingParams/default
2021-11-17T15:46:00.8928441Z === RUN   TestHandleLoggingParams/debug
2021-11-17T15:46:00.8929062Z     server_test.go:66: 
2021-11-17T15:46:00.8929637Z         	Error Trace:	server_test.go:66
2021-11-17T15:46:00.8930234Z         	Error:      	Received unexpected error:
2021-11-17T15:46:00.8931425Z         	            	couldn't open sink "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestHandleLoggingParams150626778\\001\\file.log": no sink found for scheme "c"
2021-11-17T15:46:00.8932684Z         	Test:       	TestHandleLoggingParams/debug
2021-11-17T15:46:00.8933483Z --- FAIL: TestHandleLoggingParams (0.00s)
2021-11-17T15:46:00.8934287Z     --- FAIL: TestHandleLoggingParams/default (0.00s)
2021-11-17T15:46:00.8935271Z     --- FAIL: TestHandleLoggingParams/debug (0.00s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
windows Windows platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants