Skip to content

Commit

Permalink
git: describe PR handling/requirements
Browse files Browse the repository at this point in the history
Signed-off-by: Roman Khimov <roman@nspcc.ru>
  • Loading branch information
roman-khimov committed Feb 1, 2024
1 parent e30021b commit dc3251c
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions git.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,22 @@ currently developed ones. Some additional branches MAY be present if they
can't be merged for some reason yet at the same time they have some historical
or other value.

## Pull requests

All regular changes are processed via pull requests with review requiring at
least one approval. Direct pushes to the master branch by those who have
sufficient priviledges to do that can only be done in exceptional cases or
when some process specifically requires that (like some release processes).
PRs can be merged without an approval in infrastructure-related repositories
(like Ansible roles) if they're otherwise conformant to the requirements
described here and if not merging them can affect production systems.

PRs can have a set of commits if they're related to the same problem (like
different steps to solve some issue) or the same component/code area (like
error message typo fix and logic change nearby), however different problems
(like UI typo fix and build action improvement) shouldn't be mixed in a single
PR.

## Commits

The basic unit of any accepted work is a commit (patch). Any work is accepted
Expand Down

0 comments on commit dc3251c

Please sign in to comment.