Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for error message around duplicate properties/descriptors #39

Merged
merged 1 commit into from
May 15, 2023

Conversation

nsaunders
Copy link
Owner

Description

This fixes the content of the error message that arises from duplicate properties or descriptors within a single ruleset.

For example, given this ruleset...

universal ? Rule.do
  width := nil
  width := nil -- Note the duplicate `width` property.

...the error currently reads as...

  Could not match type
           
    ( ... )
           
  with type
                          
    ( width :: CommonKeyword
    ...                   
    )  

After this change, it will read as...

  Could not match type
           
    ( ... )
           
  with type
                          
    ( width :: Measure Nil
    ...                   
    )  

...reflecting the real type of the property value.

Design considerations

N/A

Future plans

N/A

References

N/A

Code change checklist

  • Any new or updated functionality includes corresponding unit test coverage.
  • I have verified code formatting, run the unit tests, and checked for any changes in the examples.
  • I have added an entry to the Unreleased section of the CHANGELOG.

@nsaunders nsaunders merged commit 0204192 into master May 15, 2023
@nsaunders nsaunders added the defect Something isn't working label May 15, 2023
@nsaunders nsaunders deleted the feature/duplicate-error-fix branch July 27, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant