Introduce &:: operator for pseudo-elements. #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
&:
operator, previously overloaded to support both pseudo-elements and pseudo-classes, has been modified to support only pseudo-classes. Pseudo-elements now require the&::
operator instead.Design considerations
The motivation for this design change is twofold:
&:
operator is greatly simplified, e.g. several type classes removed, including some fancy-pants fundep stuff.Future plans
This might help open the door for providing some "escape hatches" as requested in #28. I would much rather offer
unsafePseudoClass
andunsafePseudoElement
functions, for example, than a singleunsafePseudo
function, because the type of pseudo-selector is important for determining whether the selector can continue to be extended with additional pseudo-classes etc.References
Code change checklist