Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Moving rails dependency as a dev one #159

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mustela
Copy link

@mustela mustela commented Mar 27, 2017

There is no need to have a rails dependency, specially because it's requiring gems like we don't actually need on specific rails apps like APIs.

sprockets/railtie: 3.6641 MiB
      sprockets/rails/context: 2.1406 MiB
        action_view/helpers: 2.1406 MiB
          action_view/helpers/form_helper: 1.6328 MiB (Also required by: action_view/helpers/form_options_helper)
            action_view/helpers/form_tag_helper: 1.5547 MiB
              action_view/helpers/text_helper: 1.4219 MiB
                action_view/helpers/sanitize_helper: 1.4219 MiB
                  rails-html-sanitizer: 1.4219 MiB
                    loofah: 1.375 MiB
                      nokogiri: 1.1719 MiB
                        nokogiri/xml: 0.4063 MiB
                        nokogiri/html: 0.3672 MiB
      sprockets: 1.3672 MiB (Also required by: sprockets/rails/context, sprockets/rails/helper)
        sprockets/environment: 0.543 MiB
          sprockets/base: 0.5117 MiB (Also required by:

@andrerpbts
Copy link
Collaborator

Hello @mustela

Do you think you can adapt it to the new version?

I think Knock is currenlty strictly linked with Rails because the controllers/routes way. However your proposal seems to make the gem more lightweight, depending only of the rails installed in the project hosting that's Knock gem. Is that right?

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants