fix(core): resolve subpath patterns in package exports correctly when constructing graph #30511
+74
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When a package has a subpath pattern like the following:
When constructing the graph the project is not picked as a dependency of others projects that import from the package using a path that matches that subpath pattern. This is currently happening because the current resolution is wrongly using
minimatch
to match those patterns instead of the Node.js spec for resolving subpath patterns.Expected Behavior
Subpath patterns should be processed after the Node.js spec and the graph should pick up dependencies when used.
Related Issue(s)
Fixes #30342