feat(core): allow customizing the location of the plugin e2e project #30390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit a805072.
☁️ Nx Cloud last updated this comment at |
tinesoft
force-pushed
the
feat/plugin-e2e-root
branch
from
5ca6d04 to
8fcd8c5
Compare
tinesoft
force-pushed
the
feat/plugin-e2e-root
branch
from
8fcd8c5 to
a805072
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When generating a new plugin with
@nx/pluginand with e2e tests, the e2e project is located in the same folder as the plugin project itself.This is fine when the plugin project is located at workspace root, but feels "weird" when the plugin is located in a sub directory (for e.g inside a
packages/my-pluginfolder). People may want to group e2e project inside ae2efolder.Expected Behavior
Allow customizing where to put the -e2e project, and default to the same folder as the plugin
Related Issue(s)
Fixes #