Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx/js): support's bun text lock file in nx release #30389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patlux
Copy link

@patlux patlux commented Mar 15, 2025

This PR fixes an error when running nx release:

Current Behavior

 NX   Updating bun lock file


 NX   Staging changed files with git


 NX   fatal: pathspec 'bun.lockb' did not match any files

Expected Behavior

 NX   Updating bun lock file


 NX   Staging changed files with git

Related Issue(s)

#30064

@patlux patlux requested review from meeroslav and a team as code owners March 15, 2025 19:47
@patlux patlux requested a review from AgentEnder March 15, 2025 19:47
Copy link

vercel bot commented Mar 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Mar 15, 2025 7:52pm

@patlux patlux force-pushed the bugfix/bun-lock-text-file branch from 5c0abeb to bfc9973 Compare March 15, 2025 19:48
// In version 1.2.0, bun switched to a text based lockfile format by default
return gte(bunVersion, '1.2.0');
} catch {
return false;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite sure which is the better default setting.

@patlux patlux changed the title support's bun text lock file in nx release fix(nx/js): support's bun text lock file in nx release Mar 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant