fix(js): Configure typescript plugin to handle non-buildable libs #29393
+177
−119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit dc54037 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
ndcunningham
force-pushed
the
fix/ts-js-exclude
branch
5 times, most recently
from
4aa24c4 to
e87bd5c
Compare
jaysoo
reviewed
Dec 18, 2024
jaysoo
reviewed
Dec 18, 2024
jaysoo
reviewed
Dec 18, 2024
ndcunningham
force-pushed
the
fix/ts-js-exclude
branch
from
e87bd5c to
67919f1
Compare
ndcunningham
force-pushed
the
fix/ts-js-exclude
branch
from
67919f1 to
dc54037
Compare
jaysoo
approved these changes
Dec 18, 2024
ndcunningham
added a commit
that referenced
this pull request
Dec 20, 2024
…9393) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Currently, we are excluding non-buildable libs from the `@nx/js/typescript` plugin. Although that allows non-buildable projects from have the build target being inferred it also as a side-effect removes the `typecheck` target which is unintended. Additionally, to breaks the pattern of being self containment that TS project solutions brings as we were modifying the root `nx.json` ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> 1. Non-buildable libs should not have a build target. 2. Non-buildable libs should have the typecheck target. 3. Buildable libs remain unchanged and should have both a build and typecheck target. 4. Remove the `exclude` from `nx.json` for non-buildable libs. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, we are excluding non-buildable libs from the
@nx/js/typescriptplugin. Although that allows non-buildable projects from have the build target being inferred it also as a side-effect removes thetypechecktarget which is unintended. Additionally, to breaks the pattern of being self containment that TS project solutions brings as we were modifying the rootnx.jsonExpected Behavior
excludefromnx.jsonfor non-buildable libs.Related Issue(s)
Fixes #