feat(core): add prefixColor property to @nx:run-commands
#29348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 86fbdd3.
☁️ Nx Cloud last updated this comment at |
nc1z
changed the title
prefixColor property to run-commandsprefixColor property to @nx:run-commands
nc1z
force-pushed
the
feat/run-commands-prefix-color
branch
from
6404389 to
a16f58c
Compare
|
Update PR description with images tested with local release vs latest release. Build/CI should pass once |
|
Your CI Pipeline Execution ↗ for commit b85afe1 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
assigned AgentEnder, FrozenPandaz and xiongemi and unassigned AgentEnder and FrozenPandaz
AgentEnder
approved these changes
Jan 28, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 28, 2025
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Running tasks in parallel, we can set prefixes. However, there is no way to label our prefixes with colors. Currently the only way is to set the entire line to the color we want. This is not ideal as users may want to keep the default colors for the logs and only want to use the prefix colors as identifiers. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> PR to add this option ## Screenshots (Examples) Tested with example screenshots below ### Before (v20.2.2 latest release) <img src="https://github.com/user-attachments/assets/dcc9b3fa-1977-4096-9dd2-3b111570c8cd" alt="description" width="300" />  ### This PR (local release) <img src="https://github.com/user-attachments/assets/6dc9eb3a-bc83-49cd-aad1-778b4f2eb354" alt="description" width="300" />  ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # --------- Co-authored-by: Isaac Mann <isaacplmann@users.noreply.github.com> (cherry picked from commit 5aec542)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running tasks in parallel, we can set prefixes. However, there is no way to label our prefixes with colors. Currently the only way is to set the entire line to the color we want. This is not ideal as users may want to keep the default colors for the logs and only want to use the prefix colors as identifiers.
Expected Behavior
PR to add this option
Screenshots (Examples)
Tested with example screenshots below
Before (v20.2.2 latest release)
This PR (local release)
Related Issue(s)
Fixes #