feat(eslint): rename eslint.config.js to eslint.config.cjs to resolve them as CommonJS #29334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
144e881 to
0fa0b93
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
0fa0b93 to
224a3ee
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
224a3ee to
29bb7fe
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
4 times, most recently
from
4506885 to
b6aa8af
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
b6aa8af to
5d373e1
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
5d373e1 to
3126725
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
3126725 to
053838f
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
053838f to
f27e9c6
Compare
AgentEnder
approved these changes
Dec 13, 2024
JamesHenry
reviewed
Dec 14, 2024
packages/workspace/src/generators/move/lib/update-project-root-files.ts
Outdated
Show resolved
Hide resolved
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
f27e9c6 to
997feab
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
aa38467 to
b682862
Compare
|
Your CI Pipeline Execution ↗ for commit 7713c79 is in progress ⏳
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
4 times, most recently
from
69715a6 to
9e2b5d6
Compare
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
2 times, most recently
from
e1563d3 to
8710fe7
Compare
… them as CommonJS
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
f5c14e9 to
5606368
Compare
JamesHenry
requested changes
Dec 18, 2024
| @@ -124,6 +124,10 @@ describe('ast-utils', () => { | |||
| ] | |||
| }).map(config => ({ | |||
| ...config, | |||
| files: [ | |||
There was a problem hiding this comment.
This doesn't seem right? This will be setting files to only resolve cts and mts? Unless eslint is doing some magical merging behind the scenes?
There was a problem hiding this comment.
This one specifically is when converting eslintrc to flat config when called from convertEslintJsonToFlatConfig. In those cases the .ts and .tsx extensions are already specified. I could add it to the ast utils as well just in case.
jaysoo
force-pushed
the
feat/eslint_config_cjs
branch
from
5606368 to
7713c79
Compare
JamesHenry
approved these changes
Dec 18, 2024
ndcunningham
pushed a commit
that referenced
this pull request
Dec 20, 2024
… them as CommonJS (#29334) This PR updates our generators to use `eslint.config.cjs` instead of `eslint.config.js` so that Node resolution will treat it as CommonJS. This solves an issue where having `"type": "module"` in `package.json` will result in an error when Node tries to resolve the config file as ESM. Also allows us to clean up out Remix generators to not have to rename to `eslint.config.cjs` to solve the same issue. <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our generators to use
eslint.config.cjsinstead ofeslint.config.jsso that Node resolution will treat it as CommonJS. This solves an issue where having"type": "module"inpackage.jsonwill result in an error when Node tries to resolve the config file as ESM.Also allows us to clean up out Remix generators to not have to rename to
eslint.config.cjsto solve the same issue.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #