fix(misc): use the ts sync generator with other bundler tasks #29170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 279a167. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
force-pushed
the
misc/infer-sync-generator-other-bundlers
branch
from
810b273 to
1e53df3
Compare
ndcunningham
reviewed
Dec 4, 2024
| @@ -38,7 +38,9 @@ export interface VitePluginOptions { | |||
| type ViteTargets = Pick<ProjectConfiguration, 'targets' | 'metadata'>; | |||
|
|
|||
| function readTargetsCache(cachePath: string): Record<string, ViteTargets> { | |||
| return existsSync(cachePath) ? readJsonFile(cachePath) : {}; | |||
| return process.env.NX_CACHE_PROJECT_GRAPH !== 'false' && existsSync(cachePath) | |||
There was a problem hiding this comment.
I guess we should update the other plugins to follow this as well.
There was a problem hiding this comment.
Yeah, some plugins have this. Others don't, but they should all have it.
ndcunningham
approved these changes
Dec 4, 2024
leosvelperez
added
the
PR status: do not merge
leosvelperez
force-pushed
the
misc/infer-sync-generator-other-bundlers
branch
from
1e53df3 to
279a167
Compare
leosvelperez
removed
the
PR status: do not merge
leosvelperez
changed the title
jaysoo
approved these changes
Dec 5, 2024
bcabanes
pushed a commit
to bcabanes/nx
that referenced
this pull request
Dec 5, 2024
…9170) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> Only targets using `tsc` trigger the `@nx/js:typescript-sync` generator to run. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Generating projects with other bundlers should also infer the `@nx/js:typescript-sync` generator in their relevant targets. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Only targets using
tsctrigger the@nx/js:typescript-syncgenerator to run.Expected Behavior
Generating projects with other bundlers should also infer the
@nx/js:typescript-syncgenerator in their relevant targets.Related Issue(s)
Fixes #