Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): handle artifact generators' path options including file extensions #29111

Merged
merged 11 commits into from
Dec 9, 2024

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Nov 28, 2024

Current Behavior

Artifact generators don't handle consistently receiving a file extension in the path option.

Expected Behavior

Artifact generators should handle receiving a file extension in the path option. If the file extension is passed, the file path will be treated as "complete" and used fully as provided. If the path provided doesn't contain a file extension, the default extension will be appended to it (or the one provided in a related option, e.g. --language, --js, etc) together with the suffix for generators that use it.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Nov 28, 2024
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 3, 2024 11:24am

@leosvelperez leosvelperez force-pushed the misc/artifact-generator-file-extensions branch from d388bd0 to be7f3be Compare December 3, 2024 11:21
@jaysoo jaysoo merged commit 28c53f9 into master Dec 9, 2024
6 checks passed
@jaysoo jaysoo deleted the misc/artifact-generator-file-extensions branch December 9, 2024 14:13
FrozenPandaz pushed a commit that referenced this pull request Dec 10, 2024
… extensions (#29111)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

Artifact generators don't handle consistently receiving a file extension
in the `path` option.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

Artifact generators should handle receiving a file extension in the
`path` option. If the file extension is passed, the file path will be
treated as "complete" and used fully as provided. If the `path` provided
doesn't contain a file extension, the default extension will be appended
to it (or the one provided in a related option, e.g. `--language`,
`--js`, etc) together with the suffix for generators that use it.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 28c53f9)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants