fix(module-federation): use 'hoisted' runtime for node to prevent issues with eager sharing #29104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues with eager sharing
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 847c5d0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
leosvelperez
approved these changes
Nov 28, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 28, 2024
…ues with eager sharing (#29104) ## Current Behavior SSR with Module Federation frequently encounters issues related to the eager resolution of shared packages. This has resulted in numerous erroneous behaviours including but not limited to: - Failure to start server - Failure to resolve remotes - Failure to server render remotes ## Expected Behavior Using the `'hoisted'` runtime provided by MF 2.0, we can ensure that SSR for Module Federation runs in an async environment, removing the issues surrounding eager consumption and resolution of shared modules. In testing, this has fixed the issues outlined above ## Related Issue(s) Fixes #27000 Fixes #27964 (cherry picked from commit 182b46c)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
SSR with Module Federation frequently encounters issues related to the eager resolution of shared packages.
This has resulted in numerous erroneous behaviours including but not limited to:
Expected Behavior
Using the
'hoisted'runtime provided by MF 2.0, we can ensure that SSR for Module Federation runs in an async environment, removing the issues surrounding eager consumption and resolution of shared modules.In testing, this has fixed the issues outlined above
Related Issue(s)
Fixes #27000
Fixes #27964