fix(nest): Fix generators (guard, interceptor etc...) path to not duplicate when provided #29084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndcunningham
added
the
scope: node
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3f51bc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
isaacplmann
approved these changes
Nov 26, 2024
ndcunningham
force-pushed
the
fix/nest-generators
branch
from
6021f3b to
9f4f206
Compare
Coly010
approved these changes
Nov 27, 2024
leosvelperez
requested changes
Nov 27, 2024
leosvelperez
requested changes
Nov 27, 2024
ndcunningham
force-pushed
the
fix/nest-generators
branch
from
9f4f206 to
6d7e7d1
Compare
ndcunningham
force-pushed
the
fix/nest-generators
branch
2 times, most recently
from
66f7339 to
3c5a8e2
Compare
…licate when provided closes: #29076
ndcunningham
force-pushed
the
fix/nest-generators
branch
from
3c5a8e2 to
3f51bc3
Compare
leosvelperez
approved these changes
Nov 27, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Nov 28, 2024
…licate when provided (#29084) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> When we run the nest generators (interceptor, resource, guard etc...) it tends to duplicate the path and leads to unexpected folder creations. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> It should generate in the path provided. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #29076 (cherry picked from commit 25c5643)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When we run the nest generators (interceptor, resource, guard etc...) it tends to duplicate the path and leads to unexpected folder creations.
Expected Behavior
It should generate in the path provided.
Related Issue(s)
Fixes #29076