feat(vite): add angular option to vitest generator

[yjaaidi]

Current Behavior

@nx/vite:vitest generator does not provide Angular support in the uiFramework options.

Expected Behavior

angular option should generate the vitest configuration just like @nx/angular:application and @nx/angular/library do.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Dec 11, 2024 10:09am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 578b0b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

---

✅ Successfully ran 6 targets

• nx affected --targets=lint,test,build,e2e,e2e-ci --base=a2670639dbf09e0676a37b0583f6948e5d63f54c --head=578b0b119e3b6769d8d9e0644797247fb412576b --parallel=3
• nx run-many -t check-imports check-commit check-lock-files check-codeowners documentation --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=a2670639dbf09e0676a37b0583f6948e5d63f54c --head=578b0b119e3b6769d8d9e0644797247fb412576b
• nx-cloud record -- nx-cloud conformance:check
• nx-cloud record -- nx sync:check
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[yjaaidi]

@nx/vite:vitest's uiFramework should be required but that would be a breaking change. Should I add it here or should we keep this for the next major?

[yjaaidi]

In order to improve tests maintainability and symmetry to production, I would love to replace fixtures like these: https://github.com/nrwl/nx/blob/8738d10446f17df7f9f30e3c94e509062feb0df2/packages/vite/src/utils/test-utils.ts

with reusable "object mothers" in testing utils:

const workspace = workspaceMother.withInferenceDisabled().build();
const app = angularAppMother.withName('my-app').withJestSetup().withSomeTests().build();
const lib = angularLibMother.withName('my-lib').build(); // no test config & no tests

createWorkspace(workspace);
createProjects([app, lib])

What do you think?

[isaacplmann]

Docs changes approved

[Coly010]

Looks good, and testing it out locally worked fine.

One addressable comment, another is more thought-provoking but doesn't need to be solved.

[leosvelperez]

This seems to be a new behavior. AFAICT, we currently don't delete a potentially previously existing target. Is this intended?

I don't think the generator should silently delete the target. It should error so the user knows there's an existing target that will override the inferred task and make the appropriate change.

[yjaaidi]

I think that I've implemented the generator a bit too much like a migration.

I'll turn this into an error.

[yjaaidi]

I just fixed this.

What should we do when vite plugin is enabled?
Should it error too if an existing target is shadowing vitest's test target?

While it is straightforward to handle this for vite plugin, what should we do for other plugins, like Nuxt?

[Coly010]

Thanks for the changes! LGTM

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.