-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(testing): use new test environment function from jest-preset-angular
#29054
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8c062fe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
3a4031e
to
611e27d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
The change looks good overall, but we need to support older versions of jest-preset-angular
where this new setup function doesn't exist.
Can you update the PR to conditionally generate the new or old setup depending on the installed version of the jest-preset-angular
package? The new setup was made available in version 14.3.0
. Let me know if you need help with it.
I rebased the PR, moved the setupZoneTestEnv
call to the template file in the @nx/jest
package where we generate the import, and added some extra test coverage.
611e27d
to
d52145e
Compare
jest-preset-angular
d52145e
to
fa9dc9f
Compare
53a8837
to
6a9dd7f
Compare
jest-preset-angular is now using setupZoneTestEnv
fa9dc9f
to
8c062fe
Compare
Something is messed up with this PR in CI at the moment and no tasks are run. To unblock it I re-created it at #29169, and I'll close this one. Thanks a lot for the contribution! |
Pull request was closed
@leosvelperez Thanks for taking care of the MR, I unfortunately had no time to get back at it this week |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
jest-preset-angular is now using setupZoneTestEnv
Current Behavior
jest-preset-angular issues a deprecation warning
Expected Behavior
this MR removes this warning
Related Issue(s)
Fixes #29165