Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rspack): buildLibsFromSource option #28994

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(rspack): buildLibsFromSource option #28994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/rspack/src/plugins/utils/apply-base-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
SwcJsMinimizerRspackPlugin,
CopyRspackPlugin,
RspackOptionsNormalized,
type DevTool,
} from '@rspack/core';
import { getRootTsConfigPath } from '@nx/js';

Expand Down
5 changes: 3 additions & 2 deletions packages/rspack/src/plugins/utils/plugins/nx-tsconfig-paths-rspack-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export class NxTsconfigPathsRspackPlugin {
apply(compiler: Compiler): void {
// TODO(Colum): Investigate the best way to handle this, currently it is not working and affecting HMR
// // If we are not building libs from source, we need to remap paths so tsconfig may be updated.
// this.handleBuildLibsFromSource(compiler.options, this.options);
this.handleBuildLibsFromSource(compiler.options, this.options);

const pathToTsconfig = !path.isAbsolute(this.options.tsConfig)
? path.join(workspaceRoot, this.options.tsConfig)
Expand Down Expand Up @@ -75,7 +75,8 @@ export class NxTsconfigPathsRspackPlugin {
options.tsConfig,
options.root,
target.data.root,
dependencies
dependencies,
true // There is an issue with Rspack that requires the baseUrl to be set in the generated tsconfig
);
this.tmpTsConfigPath = options.tsConfig;

Expand Down