Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rspack): add NxAppRspackPlugin and NxReactRspackPlugin #28987

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Nov 19, 2024

  • feat(rspack): add NxAppRspackPlugin
  • feat(rspack): add NxReactRspackPlugin

Current Behavior

We currently do not have rspack plugins to encapsulate our app, web and react support for Rspack. This leads to issues with defining configs that are supported by Crystal

Expected Behavior

Add and expose two plugins, NxAppRspackPlugin and NxReactRspackPlugin, to support building configs that are supported by crystal

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from a team as a code owner November 19, 2024 11:20
@Coly010 Coly010 self-assigned this Nov 19, 2024
@Coly010 Coly010 requested a review from leosvelperez November 19, 2024 11:20
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Nov 19, 2024 0:39am

@Coly010 Coly010 merged commit 09a01eb into master Nov 19, 2024
6 checks passed
@Coly010 Coly010 deleted the rspack/nx-rspack-app-plugin branch November 19, 2024 21:01
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants