-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add spinners when graph compute takes long time #28966
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Your CI Pipeline Execution ↗ for commit a5cd646 ⏳ is in progress.
Last updated at 2024-12-13 03:24:12UTC Sent with 💌 from NxCloud. |
2bcd9f1
to
8e88f92
Compare
bcbf720
to
4c8099c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spinner Text
Daemon Graph Spinner:
500ms
Calculating the project graph on the Nx Daemon
30s
Calculating the project graph on the Nx Daemon is taking longer than expected. Re-run with NX_DAEMON=false to see details
Nodes Spinner
Single: Creating project graph nodes with [pluginName]
Multiple: Creating project graph nodes with N plugins
Multiple (verbose): Creating project graph nodes with - plugin1\n- plugin2\n...
Dependencies Spinner
Single: Creating project graph dependencies with [pluginName]
Multiple: Creating project graph dependencies with N plugins
Multiple (verbose): Creating project graph dependencies with - plugin1\n- plugin2\n...
Metadata Spinner
Single: Creating project metadata with [pluginName]
Multiple: Creating project metadata with N plugins
Multiple (verbose): Creating project metadata with - plugin1\n- plugin2\n...
let spinner: Ora, | ||
timeout: NodeJS.Timeout, | ||
spinnerUpdateInterval: NodeJS.Timeout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create a wrapper class for ora which handles this logic.
61b0965
to
7b567f4
Compare
7b567f4
to
a5cd646
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sometimes graph computation can take longer than may be expected. In these cases we can show a spinner, and if only one plugin is still running and the daemon is disabled also show the plugin names.