Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): remove default value for hmr option in dev-server executor #28904

Merged

Conversation

leosvelperez
Copy link
Member

Upstream change: angular/angular-cli@fed31e0

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez requested a review from Coly010 November 12, 2024 14:54
@leosvelperez leosvelperez self-assigned this Nov 12, 2024
@leosvelperez leosvelperez requested review from a team as code owners November 12, 2024 14:54
@leosvelperez leosvelperez requested a review from jaysoo November 12, 2024 14:54
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Nov 12, 2024 3:05pm

@leosvelperez leosvelperez merged commit 736d2f8 into angular/v19 Nov 12, 2024
6 checks passed
@leosvelperez leosvelperez deleted the angular/v19-dev-server-remove-hmr-default-value branch November 12, 2024 15:41
leosvelperez added a commit that referenced this pull request Nov 15, 2024
…executor (#28904)

Upstream change:
angular/angular-cli@fed31e0

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant