feat(js): added a verdaccio listen address to configuration #26976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8e187db. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
|
I could not get documentation to work, maybe one of the maintainers would be so kind to run it for this PR? |
AgentEnder
force-pushed
the
feat/added-verdaccio-listen-address-configuration
branch
from
1fc59c1
to
07f53e8
Compare
AgentEnder
force-pushed
the
feat/added-verdaccio-listen-address-configuration
branch
from
21e6a41
to
89768f7
Compare
AgentEnder
force-pushed
the
feat/added-verdaccio-listen-address-configuration
branch
from
89768f7
to
a0f4ea3
Compare
Added a Verdaccio listen address to the configuration so that you are able to configure the listen address of Verdaccio.
AgentEnder
force-pushed
the
feat/added-verdaccio-listen-address-configuration
branch
from
a0f4ea3
to
9f84df3
Compare
AgentEnder
approved these changes
Jul 25, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Jul 30, 2024
Co-authored-by: William van der Vegt <william.van.der.vegt@moba.net> Co-authored-by: Craigory Coppola <craigorycoppola@gmail.com> (cherry picked from commit 50e08aa)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running Verdaccio through nx always uses localhost by default to listen to.
The Verdaccio config.yaml listen address is always overridden by the executor because it sets the --listen argument.
Expected Behavior
In our situation, where we are developing in a VM we want Verdaccio to listen to all requests by setting it to 0.0.0.0 instead of localhost.
Related Issue(s)
No Issue registered
Fixes #
Added a listen address to the Verdaccio configuration and executor.
Decided to make it a simple implementation to prevent breaking changes.