feat(linter): update eslint-config-prettier to v9 #19232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0303858. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
WikiRik
requested review from
meeroslav,
barbados-clemens,
mandarini and
FrozenPandaz
meeroslav
changed the title
meeroslav
approved these changes
Oct 5, 2023
mandarini
approved these changes
Oct 5, 2023
barbados-clemens
approved these changes
Oct 5, 2023
|
Thanks for approving and keeping this PR up to date. Let me know if there's anything more that you want me to do |
|
Hopefully, we can get it in today. Thank you for the PR and sorry it's taking this long. |
JamesHenry
approved these changes
Oct 12, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nx/eslintuses eslint-config-prettier v8 as an optional peerDependency.Expected Behavior
@nx/eslintuses eslint-config-prettier v9 as an optional peerDependency.Other instances of eslint-config-prettier have also been updated accordingly but the main focus for me was
@nx/eslintRelated Issue(s)
No issue has been created on this repo that is related to this as far as I could find.
There is a similar PR made to the
@vue/eslint-config-prettierthat does the same and this repo also needs to be updated once a new release for that is out.