fix(testing): fix generated testMatch pattern in jest config to support windows #15415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
requested review from
vsavkin,
FrozenPandaz,
AgentEnder and
barbados-clemens
as code owners
There was a problem hiding this comment.
I don't have a windows machine to verify on so I'll trust you, but @AgentEnder or @FrozenPandaz can verify if they got time.
packages/jest/src/generators/jest-project/files-angular/jest.config.ts__tmpl__
Show resolved
Hide resolved
barbados-clemens
approved these changes
Mar 3, 2023
FrozenPandaz
approved these changes
Mar 3, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generated testMatch pattern in the
jest.config.tsdoesn't work on Windows. It can't find any test files.Expected Behavior
Generated testMatch pattern in the
jest.config.tsworks on Windows. The fix is a workaround for a Jest issue jestjs/jest#7914 (comment). The new pattern is still valid and follows the micromatch syntax, which Jest uses under the hood.Related Issue(s)
Fixes #15121
Fixes #13838