fix(js): resolve shallow dependencies when building package.json #10600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For JS builds, the dependencies are now resolved shallow, dependencies will no longer inherit deps from other buildable libs in the workspace ISSUES CLOSED: 9371
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
approved these changes
Jun 6, 2022
AgentEnder
changed the title
vsavkin
added a commit
to vsavkin/nx
that referenced
this pull request
Jun 7, 2022
…son (nrwl#10600)" This reverts commit a0bf1f0.
|
We had to revert this PR because it broke the way |
|
@FrozenPandaz, can you clarify what the error was? I don't see any info in the revert and |
|
Any update on this? @vsavkin @FrozenPandaz @mckramer |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JS builds, the dependencies are now resolved shallow, dependencies will no longer inherit deps
from other buildable libs in the workspace
Current Behavior
Dependencies are currently resolved "deep". When the buildable lib has dependencies on other buildable libs in the workspace, the dependencies from those libs would be inherited.
Expected Behavior
The dependencies should be resolved shallow.
Related Issue(s)
Fixes #9371