-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default 'exclude' config for swc don't include all test file extensions #9442
Comments
barbados-clemens
pushed a commit
that referenced
this issue
Mar 25, 2022
barbados-clemens
pushed a commit
that referenced
this issue
Mar 28, 2022
include update to simplify existing patterns ISSUES CLOSED: #9442
barbados-clemens
pushed a commit
that referenced
this issue
Mar 28, 2022
include update to simplify existing patterns ISSUES CLOSED: #9442
barbados-clemens
added a commit
that referenced
this issue
Apr 11, 2022
) include update to simplify existing patterns ISSUES CLOSED: #9442 Co-authored-by: Caleb Ukle <caleb@Calebs-MBP-2.localdomain>
FrozenPandaz
pushed a commit
that referenced
this issue
Apr 13, 2022
) include update to simplify existing patterns ISSUES CLOSED: #9442 Co-authored-by: Caleb Ukle <caleb@Calebs-MBP-2.localdomain>
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Behavior
The default options for the
exclude
option in.lib.swcrc
don't match the following test file extensions:.test.ts
.test.tsx
.spec.tsx
Here are the some of the default options for reference:
Furthermore, since swc exclude uses Regex, there's no need to have both
./src/**/...
and./**/...
variations of each excluded file extension.Expected Behavior
The default swc options should be improved to exclude the file extensions listed above. They can also be simplified to remove the
./src
variants, for example:(I left the
jest-setup.ts
values the same as these don't seem to be working)Steps to Reproduce
nx generate @nrwl/js:library --name=test-lib --compiler=swc
src/lib/tests/my-test.test.ts
nx build test-lib
my-test.test.ts
hasn't been excluded.Failure Logs
N/A
Environment
The text was updated successfully, but these errors were encountered: