Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next server executor does not have default localhost hostname anymore #17852

Closed
1 of 4 tasks
myabeaver opened this issue Jun 29, 2023 · 1 comment · Fixed by #17856
Closed
1 of 4 tasks

Next server executor does not have default localhost hostname anymore #17852

myabeaver opened this issue Jun 29, 2023 · 1 comment · Fixed by #17856
Assignees
@ndcunningham
Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: bug

Comments

@myabeaver
Copy link
Contributor

Current Behavior

nx serve next-app does not use localhost as default hostname.

Expected Behavior

nx serve next-app should use localhost as default hostname.

GitHub Repo

No response

Steps to Reproduce

  1. Add a next application to your Nx mono repo.
  2. Serve it.

Nx Report

Node   : 18.16.0
@nx/next           : 16.3.2

Failure Logs

No response

Operating System

  • macOS
  • Linux
  • Windows
  • Other (Please specify)

Additional Information

https://github.com/nrwl/nx/blob/master/packages/next/src/executors/server/server.impl.ts#L48
myabeaver pushed a commit to myabeaver/nx that referenced this issue Jun 29, 2023
fix(nextjs): set localhost as hostname default
a8a0241 
closed nrwl#17852
@myabeaver myabeaver mentioned this issue Jun 29, 2023
Merged
@leosvelperez leosvelperez added the scope: nextjs Issues related to NextJS support for Nx label Jun 29, 2023
myabeaver pushed a commit to myabeaver/nx that referenced this issue Jun 29, 2023
fix(nextjs): set localhost as hostname default
863c84a 
closed nrwl#17852
ndcunningham pushed a commit to myabeaver/nx that referenced this issue Jun 30, 2023
@ndcunningham
fix(nextjs): set localhost as hostname default
8d1b017 
closed nrwl#17852
@ndcunningham ndcunningham self-assigned this Jun 30, 2023
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ndcunningham ndcunningham

Labels
outdated scope: nextjs Issues related to NextJS support for Nx type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(nextjs): set localhost as hostname default myabeaver/nx
3 participants
@ndcunningham @leosvelperez @myabeaver