fix(core): create nodes plugin fixes (#20134)

nrwl · Nov 9, 2023 · dc51a90 · dc51a90
1 parent b4faf2d
commit dc51a90
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/devkit/src/utils/replace-project-configuration-with-plugin.ts b/packages/devkit/src/utils/replace-project-configuration-with-plugin.ts
@@ -54,7 +54,7 @@ export function replaceProjectConfigurationsWithPlugin<T = unknown>(
       for (const [targetName, targetConfig] of Object.entries(node.targets)) {
         const targetFromProjectConfig = projectConfig.targets[targetName];
 
-        if (targetFromProjectConfig.executor !== targetConfig.executor) {
+        if (targetFromProjectConfig?.executor !== targetConfig.executor) {
           continue;
         }
 

diff --git a/.../workspace-plugin/src/generators/create-nodes-plugin/__snapshots__/generator.spec.ts.snap b/.../workspace-plugin/src/generators/create-nodes-plugin/__snapshots__/generator.spec.ts.snap
@@ -79,7 +79,7 @@ export const createNodes: CreateNodes<EslintPluginOptions> = [
     const projectRoot = dirname(configFilePath);
 
     // Do not create a project if package.json and project.json isn't there.
-    const siblingFiles = readdirSync(projectRoot);
+    const siblingFiles = readdirSync(join(context.workspaceRoot, projectRoot));
     if (
       !siblingFiles.includes('package.json') &&
       !siblingFiles.includes('project.json')

diff --git a/.../workspace-plugin/src/generators/create-nodes-plugin/files/src/plugins/plugin.ts.template b/.../workspace-plugin/src/generators/create-nodes-plugin/files/src/plugins/plugin.ts.template
@@ -22,7 +22,7 @@ export const createNodes: CreateNodes<<%= className %>PluginOptions> = [
     const projectRoot = dirname(configFilePath);
 
     // Do not create a project if package.json and project.json isn't there.
-    const siblingFiles = readdirSync(projectRoot);
+    const siblingFiles = readdirSync(join(context.workspaceRoot, projectRoot));
     if (
       !siblingFiles.includes('package.json') &&
       !siblingFiles.includes('project.json')