Skip to content

Commit

Permalink
fix(angular): normalize prerender and appShell options of the applica…
Browse files Browse the repository at this point in the history
…tion executor correctly (#29281)

<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #29276

(cherry picked from commit 7fca6e2)
  • Loading branch information
leosvelperez authored and FrozenPandaz committed Dec 10, 2024
1 parent ae07748 commit 7226c13
Showing 1 changed file with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,12 @@ export function normalizeOptions(
}
}

return {
...options,
appShell: angularMajorVersion < 19 ? options.appShell ?? false : undefined,
prerender:
angularMajorVersion < 19 ? options.prerender ?? false : undefined,
security,
};
let appShell = options.appShell;
let prerender = options.prerender;
if (angularMajorVersion < 19) {
appShell ??= false;
prerender ??= false;
}

return { ...options, appShell, prerender, security };
}

0 comments on commit 7226c13

Please sign in to comment.