-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LeanTask (mini task), new methods for tasks #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far. A couple comments.
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Co-authored-by: Nicholas Wiersma <nick@wiersma.co.za>
Hello Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
When can we expect a release? :) |
I am away at the moment and will be back mid next week. Alternatively you can create a PR bumping the version number and I can do the rest on my phone when I get a chance this weekend. Up to you. |
Inspired by the work of @dbuezas (#20), I added LeanTask to the current version of the scheduler and added some features.
This helps to really save RAM. On working existing projects, even 6 tasks completely clogged the heap, after which the esp8266 crashed.
The PR includes updating the documentation. Added a table with LeanTask testing results to the README.
I also added new examples. You can review them before merging branches (if you do).
Briefly: