[nrf noup] boards: thingy53: disable GPIO ISR support #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is red but the failures seem to be unrelated to the changes from this PR |
anangl
approved these changes
Oct 9, 2023
kapi-no
approved these changes
Oct 9, 2023
|
@de-nordic or @nordicjm can you take a look to see if the GPIO interrupt mode isn't needed for the MCUboot image in the Thingy:53 configuration? (MCUboot image for Thingy:53 builds correctly in the Twistter CI) |
|
I have built the Machine Learning application with this PR and it seems that MCUboot serial recovery works ok, and can be triggered while holding the Button1 while resetting device. |
nordicjm
approved these changes
Oct 11, 2023
|
MCUboot does not use GPIO interrupts, it just monitors the pin at startup, would be good to have this enabled when compiling MCUboot for any nordic device... |
nika-nordic
force-pushed
the
integrate_nrfx_3_2_0
branch
from
f74942f
to
32243ea
Compare
Change disables GPIO interrupt support in Zephyr GPIO driver, which is not obligatory for MCUboot. This is needed to reduce memory footprint. Signed-off-by: Nikodem Kastelik <nikodem.kastelik@nordicsemi.no>
nika-nordic
force-pushed
the
integrate_nrfx_3_2_0
branch
from
32243ea
to
d7b41c8
Compare
de-nordic
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change disables GPIO interrupt support in Zephyr GPIO driver, which is not obligatory for MCUboot.
This is needed to reduce memory footprint.