Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ieee802154: automatically disable radio after tx #356

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

oddstr13
Copy link
Contributor

@oddstr13 oddstr13 commented Sep 8, 2021

Fixes #351

@jonas-schievink
Copy link
Contributor

Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 8, 2021

Build succeeded:

@bors bors bot merged commit 23adfc5 into nrf-rs:master Sep 8, 2021
japaric added a commit to japaric/nrf-hal that referenced this pull request Dec 21, 2021
after PR nrf-rs#356 the radio is disabled after every `send` operation.
if one calls `send` immediately after `recv`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes nrf-rs#368
japaric added a commit to japaric/nrf-hal that referenced this pull request Dec 21, 2021
after PR nrf-rs#356 the radio is disabled after every `send` operation.
if one calls `recv` immediately after `send`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes nrf-rs#368
bors bot added a commit that referenced this pull request Jan 3, 2022
369: ieee802154: handle the transitory state TXDISABLE r=jonas-schievink a=japaric

after PR #356 the radio is disabled after every `send` operation.
if one calls `recv` immediately after `send`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes #368

---

I have checked that the programs in https://github.com/ferrous-systems/embedded-trainings-2020 work again with this change

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
bors bot added a commit that referenced this pull request Jan 3, 2022
369: ieee802154: handle the transitory state TXDISABLE r=jonas-schievink a=japaric

after PR #356 the radio is disabled after every `send` operation.
if one calls `recv` immediately after `send`, `recv` can observe the radio in the TXDISABLE state
TXDISABLE is a transitory state that leads to the final DISABLED state which the impl knows how to handle

this PR adds logic to handle the transitory TXDISABLE state

fixes #368

---

I have checked that the programs in https://github.com/ferrous-systems/embedded-trainings-2020 work again with this change

Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ieee802145 Radio.send() leaves radio transmitting after data is sent
2 participants