Bump Clojurescript for JDK 9 compatibility #84
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is a bit premature, as users who choose Java 9 will also need to choose to use CLJS 1.10. We don't want to force it on them yet. |
|
Sorry, I might be wrong but is this the case where the clojurescript version in the project overrides piggieback so people need to use 1.10? Also any idea about the test case failure? Shall I close the PR? Thanks |
|
The test failures are fixed on |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the Clojurescript version for JDK 9 compatibility. It also fixes the travis config to use lein instead of lein2.
Fixes : #77
Build failure related to repl output : https://travis-ci.org/tirkarthi/piggieback/jobs/359727935