-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add straight line support to routing #497
Conversation
Restore removed key listeners of super class to avoid duplicate calls (36d8a20)
which makes it more clear that there is no data
- update on beeline toggle - avoid distance markers wandering accross the map while routing many waypoints, because beelines are added immediately, by turning off updates in-between
- `computeKinematic` and dependencies extracted from: https://github.com/abrensch/brouter/blob/57da34d205d26f22b31f667facc99ab7507d468c/brouter-core/src/main/java/btools/router/StdPath.java - transpiled with JSweet 3.0.0 - http://www.jsweet.org/jsweet-live-sandbox/ - manual cleanup
for better comparison during development
and ensure profile text is loaded before updating route and straight line stats
(only to use different formula > 4.9)
Routing trailers are lagging behind and Canvas by default might have side effects (Plugins)
Nice work! (Not sure why you already merged the PR less than 7 minutes after its creation, though. Are you not really interested in reviews or comments, and this is just for the CI checks? Personally, I won't spend too much review effort on this now it is already on master, since you were also asking previously to suspend reviews on the branch. I guess you'll want people to create new issues for minor individual bugs from here on, and consider the overall feature done.) As for submitting and rebasing the various changes I hinted at before and which were waiting for the branch to merge: This will take me some time, sorry for that (busy currently). Anyway, now it's time to celebrate one of the most requested features has been merged 🥳 🎉 Thanks! |
Awesome work @nrenner, congrats for successfully landing that huge feature! And just in time for the summer 🚲 ;) |
I just wanted to get that out of the way. I personally like GitHub PRs as a nice overview of my larger changes, that might also be helpful for reference later on, instead of just merging, and they also make reviewing easier in case anyone feels like it, even if already merged. |
For the new beeline handling I added a new logic to the BRouter lib. It enables the transfer of all points to the BRouter lib in one request. If interested please generate a lib from This is tested with the server variante, Android test is needed and will follow. I have no server to test on - only locally - so I did it with wget.
|
Android works as well with the |
Adds client-side support for route segments to be straight lines ("as the crow flies") instead of requesting a route to follow ways. Part of #68.