-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve keyboard handling and dialog UIs #395
Improve keyboard handling and dialog UIs #395
Commits on Mar 26, 2021
-
Add more exceptions to .prettierignore
This allows `yarn prettier` to run successfully.
Configuration menu - View commit details
-
Copy full SHA for 144cc29 - Browse repository at this point
Copy the full SHA 144cc29View commit details
Commits on Mar 27, 2021
-
Fix broken Return key in export route dialog
2a43193 made it possible to press `Return` to confirm the export dialog. After 5b52abc this stopped working though, even when the text input had focus. This is due to moving the `<input>` out of the `<form>` and referencing the form's `name` attribute instead. However "The value of [the form] attribute must be the id of a <form> in the same document" according to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button. Adding such an `id` restores the `Return` key to working properly. The same change is done for the no-go form, where the same issue would otherwise affect a later patch adding similar `Return` key handling. Test Plan: - Create Route, open "Export route" dialog. - Move focus to an input field. - Press `Return`. - The file dialog for saving should open.
Configuration menu - View commit details
-
Copy full SHA for f31c379 - Browse repository at this point
Copy the full SHA f31c379View commit details
Commits on Mar 28, 2021
-
5b52abc broke importing no-go areas, in particular after choosing a file and clicking on "Load" nothing would happen. This is due to renaming the `<input>`'s `<id>` which is still referenced in `NogoAreas.js` by its old name. Undoing the rename resolves the issue. Test Plan: - Open "Load no-go areas" dialog. - Click on "Browse" and select GeoJSON file (e.g. as referenced in #161). - Click on "Load". - The no-go areas should be added to the map.
Configuration menu - View commit details
-
Copy full SHA for ef37b65 - Browse repository at this point
Copy the full SHA ef37b65View commit details
Commits on Mar 29, 2021
-
Show missing filename in load no-go areas dialog
5b52abc copied `<label>` and `<input>` from the `loadedittrackForm` for consistency, but missed to add some corresponding code to `NoGoAreas.js`. After completing the implementation, the filename for loading no-go areas is now displayed after selecting a file just like in the "Load track as route" dialog. Test Plan: - Open "Load no-go areas" dialog. - Browse and select file. - The filename should now be shown next to "Browse".
Configuration menu - View commit details
-
Copy full SHA for 8b9fda4 - Browse repository at this point
Copy the full SHA 8b9fda4View commit details
Commits on Mar 30, 2021
-
Allow Return key to accept dialog when loading no-go areas or track a…
…s route After ca53080 added Return key handling to the "Delete route" dialog, only the "Load no-go areas" and "Load track as route" dialogs were still missing similar functionality. The implementation is based on 2a43193. Test Plan: - Open "Load no-go areas" or "Load track as route" dialog. - Press Space or Return to open file dialog, choose file, Tab out of file input and press Return to confirm modal. - Notice not having to Tab to the respective confirmation button.
Configuration menu - View commit details
-
Copy full SHA for eb8a7a9 - Browse repository at this point
Copy the full SHA eb8a7a9View commit details
Commits on Mar 31, 2021
-
Set focus in modals to first input field by default
After invoking a shortcut, some dialogs required pressing `Tab` or using the mouse until focus was moved to the primary input field. By moving the focus automatically, users can start typing right away. This is particularly useful in conjunction with the `Return` key for confirming the dialog. Test Plan: - Press `X` to open "Export" dialog: "Name" field has focus. - Press `Shift+O` to open "Load track as route": "Trackfile" is focussed, file dialog opens with `Space`. - Check "Load no-go area" dialog. - Check "POI name" dialog.
Configuration menu - View commit details
-
Copy full SHA for 13794c3 - Browse repository at this point
Copy the full SHA 13794c3View commit details
Commits on Apr 1, 2021
-
Select parts of trackname in export dialog for easier overwriting
Users might want to assign custom tracknames, which requires deleting the default name either entirely or parts of it. By pre-selecting parts of the trackname, users can start typing right away after opening the dialog. `Ctrl+A` to select everything is still possible, but keeping the distance in the filename by default comes in handy, e.g. when using a file manager not displaying the track length. NB: Might need adaptation once trackname validation becomes less strict, i.e. currently "(" and "->" as specified in the message catalog are replaced with ' - ' by the validator before being inserted into the dialog. Test Plan: - Open "Export" dialog ("Location - Other Location - 2km") - Open "Export" dialog for roundtrip ("Location - 1km") - In both cases the complete trackname except for the distance information (including separator) should be selected. - No unwanted behaviour even if Nominatim is slow or down.
Configuration menu - View commit details
-
Copy full SHA for 7edae91 - Browse repository at this point
Copy the full SHA 7edae91View commit details