Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show inverted polygon for allowed zone #352

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

nrenner
Copy link
Owner

@nrenner nrenner commented Dec 4, 2020

Out of interest I experimented with adding an inverted polygon for the limited area, as a potential addition to #347.

  • shows the outside area in a darker shade
  • shows a not-allowed cursor
  • stops clicks on the polygon and thus prevents adding markers outside the area - but cannot avoid dragging markers out

grafik

@bagage what do you think, would that be a useful addition (I don't mind if not)?

@nrenner nrenner requested a review from bagage December 4, 2020 17:24
@bagage
Copy link
Collaborator

bagage commented Dec 4, 2020

Very nice enhancement @nrenner, it isn't much more code and the result looks way better like that!

Do you think we could do a release for that to be available on brouter.de main instance? It would be a really great enhancement for French users :).

@bagage bagage merged commit 1d78e03 into master Dec 4, 2020
@nrenner
Copy link
Owner Author

nrenner commented Dec 4, 2020

Do you think we could do a release for that to be available on brouter.de main instance?

Done.

@nrenner nrenner deleted the limit-area-inverted branch February 9, 2021 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants