-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CyclOSM in the default selection of available layers #290
Conversation
I deliberately removed CyclOSM even as optional layer in c838b55, except for France, where its the default. This was after our mail exchange with Jocelyn (openstreetmap.fr admin) when it turned out, that our old OpenCycleMap usage (as optional layer) was 1/6th of the whole server usage. Has anything changed since then? |
Hi, from my understanding of the stats https://munin.openstreetmap.fr/osm11.openstreetmap.fr/osm166.openstreetmap.fr/index.html |
Hi Norbert, I'm sorry, I completely forgot not having it in the default selection was intentional. I've just crunched some stats. We should be serving around 1M tiles per day currently. In total, we served 14M tiles in the last 14 days, but this is to be taken cautiously since this includes 4.4M tiles served for https://carte.velo-iledefrance.fr/ (map of covid19 temporary cycleways around Paris, launched last week). If my stats are correct, we should serve about 60k tiles per day for BRouter currently. This is above the 18k tiles we were discussing last November, but this is expected since CyclOSM is default for French users while OpenCycleMap was featured but optional for everyone. From these numbers, if my understanding is correct, having CyclOSM as a featured but optional layer for everyone (but kept default for French users) would represent something like 18k extra tiles per day, max. If these numbers are correct, I think this is a reasonable increase (18k extra tiles over 1M tiles served per day in total). If we can confirm these expected numbers, I'll loop again by email with OSM-FR before merging anything. |
I think that we need our own rendering server. I'm just still struggling with which way I want to go for financing. I do have more comments on numbers but need to look them up again first. |
My proposal in November was to add it to the optional list (i.e. to the additional list behind the "More" button), to avoid too high usage and then maybe see what the actual request numbers are. The 18k requests per day were when Thunderforest layers were moved to that optional list for a short time before removal. Thunderforest layers in the default selection, like in this PR, had much higher numbers around 96k per day: Thunderforest single tile requests around May in 2019:
Our route segment request numbers have more than doubled since last year, so I accounted for that as a rough estimate in the "*2" row. Another comparison is our openstreetmap.org tile usage that I saw recently: in the Top 10K websites using openstreetmap.org tiles [1] we're at rank 153: Assuming this is tile requests per month in February ¹ 2020 (29 days):
¹ not really outdoor season in Europe yet |
Sure, but this includes German and French users (and French users already have CyclOSM as default). On my side, from May, 4th to May 20th, I have:
This amounts to basically 3M tiles currently served per month for BRouter. This is to be compared to 2.3M tiles served over the same period for cyclosm.org (our main demo website). Third referrer is Umap with 700k tiles over the same period. Overall, we are serving around 1M tiles per day. Given these numbers, I think we could reasonably step up a bit with CyclOSM in BRouter. If I understood correctly, current situation is CyclOSM is default for French users and in the "More" list for everyone else. We could possibly push CyclOSM to the default selection of alternative layers and see if this is manageable. This would result in a likely 20-100k extra tiles. |
No, CyclOSM is the default for French users, but not available at all for everyone else, not even in the "More" list. This is because even with our lowest number, the 18k/day or 0.5M/month, the comment from Jocelyn was "The usage seems a bit high compared to what is currently served". The total number you had in November was 3M per month for CyclOSM. So 0.5M would have been 1/6th of that. |
Alright so let's go one step at a time, we could propose CyclOSM in the More list ? |
Having CyclOSM in the main list would of course be great and what you would expect from a bike-focused app. I'm very unsure what usage is still acceptable, maybe propose both options, ultimately it's on the admins to decide? |
See https://listes.openstreetmap.fr/wws/arc/tech/2020-08/msg00000.html. This is fine for OSM-Fr to add CyclOSM in the list of layers available for everyone. Thanks! |
Good news, thanks! So as discussed, we start by adding it to the list of configurable layers under "More" first? |
Yes,I would be in favor of adopting a progressive inclusion along next two versions, if that's fine for you. Next version: offer cyclosm under the "More" list for everyone. Best |
Use `pseudo_language_code` to keep it the default for French users, but not display the (wrong) language prefix in the layer tree.
I see "0.13.0 - No due date 100% complete" but today is 16th OpenStreetMap anniversary ;-). |
Perfect. Happy anniversary! |
@Phyks now that quite some time has passed, what is the opinion on this? |
@Phyks @nrenner Do we have an update on this feature? I see that there are waymarked trails as a layer but one of the main benefits of cyclosm is that it displays bicycle infrastructure (bike lanes, separate cycleways, cycle streets, etc). EDIT: I noticed it under the optional layers. Perhaps it makes more sense to include CyclOSM under Cycling (Waymarked Trails). |
CyclOSM is now featured on osm.org. I expect BRouter traffic to be at most a duplicate usage of osm.org. Therefore, I see no specific reason (from CyclOSM side) to not include it in default selection. This is, of course, up to brouter-web to decide in the end given expected usage / benefit / quality of service of CyclOSM. |
No description provided.