Bootstrap upgrade

[bagage]

Fixes #107

I'm not sure how this should be tackled. For now I'm just trying to fix broken things.

Still to do:

• reput the brand in navbar right corner? What was the purpose of it? cf https://stackoverflow.com/questions/49434504/using-bootstrap-4-how-to-align-navbar-brand-on-the-right
• 
• 
• 

[nrenner]

I'm not sure how this should be tackled.

Don't know either, the migration guide is a bit long and we don't really use that much. Maybe by going through index.html and checking everything that looks like Bootstrap?

reput the brand in navbar right corner? What was the purpose of it?

Yes, please. To have the profile dropdown in the leftmost position of the screen, in order not to hide the route while trying out various profiles and see how the route changes. Also, I thought it just looks weird to open this huge dropdown somewhere in the middle of the screen.

[bagage]

OK I think this is it - reviews are always welcome :).

[nrenner]

Looking good overall.

Some things I found:

• the stats labels in the footer are not hidden on small/mobile screens
• the profile message (warning after upload / on error) is not visible, just blank space
• the delete route modal title is messed up (bootbox)

[bagage]

Thanks, indeed I missed some. Fortunately there were easy fixes.

Regarding the modal issue, I have to upgrade bootbox dependency but gulp is not finding it, eg gulp log is not listing gulp-debug: node_modules/bootbox/dist/bootbox.all.min.js as expected (even when I manually override main entry). I'm trying to understand why but yet I failed to do so…

[bagage]

Hmm, we are actually filtering out *.min.js files in gulp process. Is that on purpose?

One way is to use the non minified file instead:

        "bootbox": {
            "main": [
                "src/bootbox.all.js"
            ]
        },

But the other way would be to just use .min.js files as well. I know that we minify file later in the process for releases, but do we need non-minified libraries too?

[nrenner]

Thanks a lot for taking on this tedious task!

[nrenner]

Hmm, we are actually filtering out *.min.js files in gulp process. Is that on purpose?

I think so, but can't remember why. Probably because some projects had both the src and min files in their main.

I think I haven't seen a case yet where we would have needed the minified file, non-minified or source files were always available and sufficient.

bower.json spec says:

Do not include minified files.

The reason for me is to have non-minified library code available for debugging and proper stack traces, both in debugging mode and also in the release sourcemap.