Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reverse route / delete last point buttons #179

Merged
merged 3 commits into from
May 15, 2019

Conversation

bagage
Copy link
Collaborator

@bagage bagage commented May 11, 2019

Fixes #54
Fixes #33

@bagage bagage changed the title Add reverse route button Add reverse route / delete last point buttons May 12, 2019
@nrenner
Copy link
Owner

nrenner commented May 14, 2019

No sure we should use the undo icon (fa-undo) for something that isn't really an undo function, maybe one day we get around actually implementing a proper undo feature.

Maybe something like fa-long-arrow-left stacked with fa-map-marker instead?

@bagage
Copy link
Collaborator Author

bagage commented May 14, 2019

I started to replace undo icon but currently it does not look OK:

image

I'm not sure how we can stack then vertically, if you have an idea feel free to modify this MR directly :).

@nrenner
Copy link
Owner

nrenner commented May 15, 2019

It gets horizontally aligned without fa-lg, and I moved the marker with margin and colored it gray so they're better distinguishable, but I still don't like it:
Screenshot_2019-05-15 BRouter Web Client(2)
Screenshot_2019-05-15 BRouter Web Client(3)

'<span class="fa-stack"><i class="fa fa-map-marker fa-stack-1x" style="margin: -2px 0 0 2px; color: gray;"></i><i class="fa fa-long-arrow-left fa-stack-1x"></i></span>',

I guess this one is better? Marker gray to indicate fading and to highlight left caret as back/backspace.

Screenshot_2019-05-15 BRouter Web Client(1)

'<span><i class="fa fa-caret-left"></i><i class="fa fa-map-marker" style="margin-left: 1px; color: gray;"></i></span>',

@bagage
Copy link
Collaborator Author

bagage commented May 15, 2019

Yes last one is looking good IMHO.

@nrenner nrenner merged commit d799f94 into nrenner:master May 15, 2019
@bagage bagage deleted the 54-add-reverse-button branch May 27, 2019 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button for reversing the direction of the track Delete last point
2 participants