Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route line fully covers street names - set default transparency slider value to partially transparent. #36

Closed
matkoniecz opened this issue Oct 17, 2015 · 7 comments
Milestone

Comments

@matkoniecz
Copy link

The pink line fully covers street names. I noticed that I need separate tab for map to check road names of route.

I propose avoid fully covering road - by making line partly transparent or by offsetting it from road.

Maybe change style only on high zooms.

I prefer old style (I am pretty sure that there was a blue, partially transparent line).

@matkoniecz matkoniecz changed the title line fully covers street names route line fully covers street names Oct 17, 2015
@poutnikl
Copy link

there is the tranparency level slider at the right edge of the left panel. Use it to have both the route and the names visible.

Question: why not to apply the slider on route overlay as well ?

Considering general topic of marking planned route and generally the whole current hiking/cycling route overlay....... why not to use similar approach as the one used by Elevate vector map theme for OpenAndromaps that I use for Locus with Brouter?

http://www.openandromaps.org/en/legend/elevate-mountain-hike-theme

Quoting:

  • Hiking routes are rendered below paths and tracks starting at zoom level 14 (OruxMaps: 15), till level 13 (OruxMaps: 14)transparent above them.
  • Cycling routes are rendered below streets starting at zoom level 14 (OruxMaps: 15), till level 13 (OruxMaps: 14) transparent above them.

@matkoniecz
Copy link
Author

there is the tranparency level slider at the right edge of the left panel. Use it to have both the route and the names visible.

Thanks! I will change title of issue as I think that different default would be better (most people will never notice slider).

@matkoniecz matkoniecz changed the title route line fully covers street names route line fully covers street names - set default transparency slider value to partially transparent. Oct 18, 2015
@matkoniecz
Copy link
Author

For me 67% works well - both route is visible and street names are readable.

@poutnikl
Copy link

It is for me hard to imagine I would not notice it.. :-) Perhaps neon blinking ? :-D (joking)

@nrenner
Copy link
Owner

nrenner commented Oct 29, 2015

Thanks for the constructive feedback.

The old route line style simply was the Leaflet standard (which has changed in the upcoming version). The transparent (0.5) blue color had a bad contrast especially on the OpenCycleMap. Changing the color has been requested on the BRouter Group [1][2].

I might have gone too far for maximum contrast (opacity 1.0), will think about making it more transparent initially.

At this point, I'm a bit reluctant to making things more complicated by introducing zoom- or layer-dependant styling.

What I would like to investigate are new CSS features (ideally having a Leaflet plugin I just need to add):

@nrenner nrenner added this to the 0.6.0 milestone Oct 29, 2015
@poutnikl
Copy link

I agree with keeping things simple yet effective.

An opaque but dashed route line would make sense too, keeping well visible both the route and the road style as well.

@matkoniecz
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants