Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve mobile responsivity #296

Closed
8 tasks done
bagage opened this issue May 21, 2020 · 2 comments · Fixed by #383
Closed
8 tasks done

improve mobile responsivity #296

bagage opened this issue May 21, 2020 · 2 comments · Fixed by #383
Assignees
@bagage
Labels
enhancement
Milestone
0.16.0

Comments

@bagage
Copy link
Collaborator

bagage commented May 21, 2020 •
edited by nrenner
Loading

I tweaked some files on my fork to improve web experience via PWA (progressive web app).

I'll submit a PR for that, I think we could do a TWA too quite easily so that brouterweb can be installed via app store (play store or fdroid or such). It will require #286.

I think we could improve UI in a few areas:

  • put everything on a single line at the bottom
  • put everything on a single column on the left side (or maybe remove some buttons on mobile look zoom buttons)
  • improve the search icon quality that looks blurry on mobile (need to update the library but blocked by upstream issue yet Cannot extend L.Control.Geocoder since version 2.0.0 perliedman/leaflet-control-geocoder#324)
  • somehow improve the navbar which is not very convenient on mobile won't do that here, it is a rather separate issue
  • improve profile/alternative selection on mobile (you need double click to select an item but it seems to take effect on single click too - but related to previous point)
  • make modals fullscreen?
  • remove fullscreen button from profile layers selection on small screens
  • maybe more…

For now it looks like this:

Screenshot_20200521-134854_Firefox_Preview
@bagage bagage self-assigned this May 21, 2020
@nrenner
Copy link
Owner

nrenner commented May 22, 2020

Yes, going full screen would be nice.

Not quite clear to me: is the icon required for your PR or a potential future TWA?

@bagage
Copy link
Collaborator Author

bagage commented May 22, 2020

Not strictly required, a placeholer icon is fine too. And twa is the last item to do, once everything else is fixed.

bagage added a commit to bagage/brouter-web that referenced this issue May 24, 2020
@bagage
Improve stats footer on mobile nrenner#296
4dd074c
bagage added a commit that referenced this issue May 24, 2020
@bagage
Improve stats footer on mobile #296
d8b3a21
bagage added a commit to bagage/brouter-web that referenced this issue May 24, 2020
@bagage
Improve stats footer on mobile nrenner#296
5d0bb10
bagage added a commit that referenced this issue May 24, 2020
@bagage
Improve stats footer on mobile #296
a358aed
@bagage bagage mentioned this issue May 24, 2020
Merged
bagage added a commit that referenced this issue Mar 9, 2021
@bagage
Hide expand icon on moblie (#296)
b0d4c28
@nrenner nrenner mentioned this issue Mar 9, 2021
Closed
@bagage bagage mentioned this issue Mar 10, 2021
Merged
@nrenner nrenner added this to the 0.16.0 milestone Mar 25, 2021
nrenner added a commit that referenced this issue Mar 26, 2021
@nrenner
Update leaflet-control-geocoder (#296)
fbcfd8c 
Switch BR.Search to ES6 class because L.Control.Geocoder is now an ES6 class and Leaflet L.Class.extend doesn't work anymore (undefined).
stefankeidel added a commit to cxberlin/brouter-web that referenced this issue Apr 8, 2021
@stefankeidel
Merge remote-tracking branch 'upstream/master'
d952378 
* upstream/master:
  Update France Go area to 10km
  Update bootstrap-select dep to avoid error on mobile
  Improve modal dialogs consistency
  Rename dialog
  Make modals fullscreen on mobile
  Hide expand icon on moblie (nrenner#296)
  Gray out unselectable layers (nrenner#381)
  Update translations
  Translate overlay type and fix width computation (nrenner#379)
  Use plural form when multiple overlays are active (nrenner#378)
  Add message if no elevation data is available (nrenner#373)
  Add missing translatable content (nrenner#376)
  Remove debug code
  Update translations
  Add What's new modal (nrenner#372)
  Add Babel and core-js & regenerator polyfills (nrenner#367)
@nrenner nrenner mentioned this issue Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bagage bagage

Labels
enhancement
Projects
None yet
Milestone
0.16.0
Development

Successfully merging a pull request may close this issue.

Feat/improve mobile bagage/brouter-web
2 participants
@nrenner @bagage