-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing nogo weight when loading nogos #174
Comments
* Nogo weight was not set when loading nogos with a default weight value. * The URL would show up "NaN" values upon reloading the web interface after having loaded some nogos. Fix nrenner#174.
The commit history is lost because of squashing, but I think you first passed Lines 417 to 421 in 5f89287
I would prefer to manually set the layer option here instead of PR #175, something like this: onEachFeature: function (feature, layer) {
layer.options.nogoWeight = feature.properties.nogoWeight || nogoWeight;
} |
* Nogo weight was not set when loading nogos with a default weight value. * The URL would show up "NaN" values upon reloading the web interface after having loaded some nogos. Fix nrenner#174.
Indeed, this is a very nice idea to have it handled this way. I updated the PR accordingly, thanks for the feedback! |
* Nogo weight was not set when loading nogos with a default weight value. * The URL would show up "NaN" values upon reloading the web interface after having loaded some nogos. Fix nrenner#174.
Hi,
It seems loading nogos from a GeoJSON while specifying a (positive) weight does not work and the URL for the query to the BRouter server is not updated accordingly.
It seems that when loading GeoJSON data here, the properties of the features in the GeoJSON object are not loaded by Leaflet (they should be loaded into options in Leaflet, for this part to work).
I am really not sure what is happening here, I'm almost sure this was fully tested and working when the PR got merged. Maybe this is due to a Leaflet update?
Best,
The text was updated successfully, but these errors were encountered: