Update to syn 0.12 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tracking down the cause of rust-lang/rust#48223 I found that the `syn` crate was compiled twice and with different features than the ones that Cargo activated. It turns out that the RLS pulls in this crate which depends on `syn`, and this crate enabled the `full` feature in `syn` where a standalone build of Cargo didn't activate such a feature. Consequently this means that when Cargo was compiled for the RLS and for itself it was compiled twice! I initially started out by removing the dependency on the `full` feature in this crate (hurray faster compiles too!) but ended up updating to syn 0.12 as well which is the updated version that works better with spans and such. I've also done some reorganization of the tests cases to hopefully be more amenable to CI as well, but let me know if any of it looks odd!
Looks fine, but out of curiosity, why is this easier for CI? Thanks for the PR! |
|
Oh I mostly figured it'd be easiest for CI to mirror just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tracking down the cause of rust-lang/rust#48223 I found that the
syncratewas compiled twice and with different features than the ones that Cargo
activated. It turns out that the RLS pulls in this crate which depends on
syn,and this crate enabled the
fullfeature insynwhere a standalone build ofCargo didn't activate such a feature. Consequently this means that when Cargo
was compiled for the RLS and for itself it was compiled twice!
I initially started out by removing the dependency on the
fullfeature in thiscrate (hurray faster compiles too!) but ended up updating to syn 0.12 as well
which is the updated version that works better with spans and such.
I've also done some reorganization of the tests cases to hopefully be more
amenable to CI as well, but let me know if any of it looks odd!