Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gis push --no-interactive #10

Closed
nqminhuit opened this issue Mar 18, 2022 · 0 comments · Fixed by #98
Closed

gis push --no-interactive #10

nqminhuit opened this issue Mar 18, 2022 · 0 comments · Fixed by #98
Labels
enhancement Improvement over existing functions
Milestone

Comments

@nqminhuit
Copy link
Owner

nqminhuit commented Mar 18, 2022

When pushing multiple modules to repos, it might be dangerous if user mis-pushes on some repos

  • Provide a question to ask for user's confirmation, should be enable by default, can be disabled with --no-interactive flag. OR:
  • Provide an interactive way for user to push.
  • Or both?

Edit:
We have implemented the push command:

  • prompt for confirmation: Are you sure you want to push to remote '<branch_name>' [Y/n]
  • gis push <branch_name> will go through all submodules having <branch_name> and push to existing remote
  • gis push -f <branch_name> will go through all submodules having <branch_name> and force push to existing remote
  • gis push -r <branch_name> will go through all submodules having <branch_name> and push to new remote

What left is the --no-interactive flag.

@nqminhuit nqminhuit added this to the 1.0.0 milestone Mar 19, 2022
@nqminhuit nqminhuit added the enhancement Improvement over existing functions label Mar 19, 2022
@nqminhuit nqminhuit modified the milestones: 1.0.0, 2.0.0 Apr 2, 2022
@nqminhuit nqminhuit changed the title [feature] gis push confirm [feature] gis push -q Apr 2, 2022
@nqminhuit nqminhuit changed the title [feature] gis push -q gis push -q Nov 3, 2023
@nqminhuit nqminhuit modified the milestones: 2.0.0, 2.1.0 Jun 22, 2024
@nqminhuit nqminhuit changed the title gis push -q gis push --no-interactive Jun 25, 2024
@nqminhuit nqminhuit changed the title gis push --no-interactive gis push --no-interactive Jun 25, 2024
@nqminhuit nqminhuit modified the milestones: 2.1.0, 2.0.0 Jul 10, 2024
nqminhuit pushed a commit that referenced this issue Jul 10, 2024
nqminhuit pushed a commit that referenced this issue Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement over existing functions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant