Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: omit nyc config for all tap versions above 18 #465

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: omit nyc config for all tap versions above 18 #465

merged 1 commit into from
Aug 6, 2024

Conversation

wraithgar
Copy link
Member

No description provided.

@wraithgar wraithgar requested a review from a team as a code owner August 5, 2024 17:39
hashtagchris
hashtagchris reviewed Aug 5, 2024
View reviewed changes
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have renamed the config setting to tap18Plus, but we can also do that in the future when we need to make a distinction between 18 and some higher release.

hashtagchris
hashtagchris approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended to approve with my previous comment

@wraithgar wraithgar merged commit 6a2200d into main Aug 6, 2024
20 checks passed
@wraithgar wraithgar deleted the gar/tap-21 branch August 6, 2024 14:22
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
Merged
wraithgar pushed a commit that referenced this pull request Aug 13, 2024
@github-actions
chore: release 4.23.2 (#468)
bba605f 
🤖 I have created a release *beep* *boop*
---


##
[4.23.2](v4.23.1...v4.23.2)
(2024-08-13)

### Bug Fixes

*
[`fa37073`](fa37073)
[#469](#469) proper workspace
tap config for tap18 and up (@wraithgar)
*
[`6a2200d`](6a2200d)
[#465](#465) omit nyc config for
all tap versions above 18 (#465) (@wraithgar)
*
[`6ee703d`](6ee703d)
Don't restrict length for commit message footer (#467) (@hashtagchris)
*
[`87d3ed9`](87d3ed9)
[#466](#466) update codeql
runner version (#466) (@wraithgar)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashtagchris hashtagchris hashtagchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @hashtagchris